Skip to content

chore(internal): migrate config._raise to native config#17968

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
brettlangdon/native.raise.config
May 11, 2026
Merged

chore(internal): migrate config._raise to native config#17968
gh-worker-dd-mergequeue-cf854d[bot] merged 1 commit into
mainfrom
brettlangdon/native.raise.config

Conversation

@brettlangdon
Copy link
Copy Markdown
Member

Description

We move the storage of config._raise to be in src/native/config.rs.

We want to utilize this config option from native code without wanting to call into Python to get the value.

Testing

Risks

Additional Notes

@brettlangdon brettlangdon added the changelog/no-changelog A changelog entry is not required for this PR. label May 7, 2026
@brettlangdon brettlangdon requested review from a team as code owners May 7, 2026 19:33
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/internal/native/_native.pyi                                     @DataDog/apm-core-python
ddtrace/internal/settings/_config.py                                    @DataDog/python-guild @DataDog/apm-sdk-capabilities-python
src/native/config.rs                                                    @DataDog/apm-core-python
tests/tracer/test_global_config.py                                      @DataDog/apm-sdk-capabilities-python @DataDog/apm-core-python

@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 7, 2026

Benchmarks

Benchmark execution time: 2026-05-07 20:11:27

Comparing candidate commit 8269bd6 in PR branch brettlangdon/native.raise.config with baseline commit 7834861 in branch main.

Found 0 performance improvements and 7 performance regressions! Performance is the same for 591 metrics, 4 unstable metrics.

scenario:iastaspects-index_aspect

  • 🟥 execution_time [+10.998µs; +16.437µs] or [+8.908%; +13.313%]

scenario:iastaspects-ljust_noaspect

  • 🟥 execution_time [+20.875µs; +27.435µs] or [+7.902%; +10.385%]

scenario:iastaspects-stringio_aspect

  • 🟥 execution_time [+576.997µs; +637.139µs] or [+14.846%; +16.394%]

scenario:iastaspectsospath-ospathbasename_aspect

  • 🟥 execution_time [+90.832µs; +98.605µs] or [+21.426%; +23.260%]

scenario:iastaspectssplit-rsplit_aspect

  • 🟥 execution_time [+11.470µs; +16.051µs] or [+7.393%; +10.345%]

scenario:span-start

  • 🟥 execution_time [+1.471ms; +1.637ms] or [+9.556%; +10.639%]

scenario:telemetryaddmetric-1-count-metric-1-times

  • 🟥 execution_time [+178.982ns; +209.344ns] or [+8.566%; +10.019%]

@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit bb65de3 into main May 11, 2026
1158 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the brettlangdon/native.raise.config branch May 11, 2026 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants