chore(ci): resolve flaky test failures in hooks/tests/test-run#17976
Draft
vlad-scherbich wants to merge 1 commit intomainfrom
Draft
chore(ci): resolve flaky test failures in hooks/tests/test-run#17976vlad-scherbich wants to merge 1 commit intomainfrom
vlad-scherbich wants to merge 1 commit intomainfrom
Conversation
vlad-scherbich
added
the
changelog/no-changelog
Codeowners resolved as |
vlad-scherbich
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The test mock for
run-fmt.shwas missing agit diffvariant, sothree tests would fail whenever the working tree had dirty
.pyfiles.Added the missing pattern to the mock so all 22 tests pass regardless
of local tree state.
Testing
sh hooks/tests/test-run-fmt.sh— 22 passed, 0 failed.