bug/feat(llmobs): expose input_documents/output_documents on span processor#17983
Open
MrinalJain17 wants to merge 2 commits intoDataDog:mainfrom
Open
bug/feat(llmobs): expose input_documents/output_documents on span processor#17983MrinalJain17 wants to merge 2 commits intoDataDog:mainfrom
MrinalJain17 wants to merge 2 commits intoDataDog:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 13d3236b57
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
Author
|
Hello @ZStriker19 @Yun-Kim @gnufede Would appreciate if you can take a look at this. The issue can lead to (sensitive) document content being leaked to Datadog LLMobs silently, without the ability for users to redact. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The span processor (
register_processor/enable(span_processor=...)) exposesinputandoutput(messages/values) for mutation, but not documents. Embedding and retrieval span documents pass through to Datadog without any way for users to redact or modify them.This adds
input_documentsandoutput_documentsfields toLLMObsSpan, following the same populate-before/write-back-after pattern used byinputandoutput.Usage
Testing
Added two tests in
TestLLMIOProcessing:test_document_processor_redact— mutate document text in placetest_document_processor_remove— clear documents by setting to[]Risks
None. The change is backward-compatible —
input_documentsandoutput_documentsdefault to[], so existing processors that do not reference them are unaffected.Additional Notes
Related issues: #11179
The fix in #13479 was only partial. For enterprise use-cases, being able to redact sensitive information is critical.