Skip to content

Emmett.butler/internal package#17991

Draft
emmettbutler wants to merge 4 commits intomainfrom
emmett.butler/internal-package
Draft

Emmett.butler/internal package#17991
emmettbutler wants to merge 4 commits intomainfrom
emmett.butler/internal-package

Conversation

@emmettbutler
Copy link
Copy Markdown
Collaborator

Description

Testing

Risks

Additional Notes

@emmettbutler emmettbutler requested review from a team as code owners May 8, 2026 21:14
@emmettbutler emmettbutler marked this pull request as draft May 8, 2026 21:14
@chatgpt-codex-connector
Copy link
Copy Markdown

💡 Codex Review


P1 Badge Restore GitHub workflows to the repository root

Because this commit moves the workflow to dd-trace-py/.github/workflows, GitHub will no longer discover it: GitHub searches only the repository root's .github/workflows directory for workflow files (https://docs.github.com/en/actions/concepts/workflows-and-actions/workflows). I checked this commit and there is no root .github directory left, so pull request and push automation such as PR-name linting, backports, and package/version generation will stop running unless the workflows stay at the root or are replaced there.


"ddtrace-internal @ file:../ddtrace-internal",

P1 Badge Avoid publishing a local file dependency

This required dependency is a local direct reference, which works only from a checkout containing ../ddtrace-internal; published ddtrace distributions would either be rejected by PyPI/standards-compliant indexes or leave users installing from a wheel/sdist with a dependency that points at a nonexistent local path. Setuptools documents that package indexes do not accept direct URL dependencies (https://setuptools.pypa.io/en/latest/userguide/dependency_management.html#direct-url-dependencies), so ddtrace-internal needs to be published and referenced by version, bundled, or kept out of released metadata.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant