Skip to content

chore(version): fix version.py for python3.9#18066

Merged
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
dubloom/fix-main-microbenchmmarks
May 13, 2026
Merged

chore(version): fix version.py for python3.9#18066
gh-worker-dd-mergequeue-cf854d[bot] merged 2 commits into
mainfrom
dubloom/fix-main-microbenchmmarks

Conversation

@dubloom
Copy link
Copy Markdown
Contributor

@dubloom dubloom commented May 13, 2026

Description

This PR: #17964 broke main because it introduced code that is incompatible with python3.9. However, microbenchmarks are running on python3.9 which broke http microbenchmarks.

This PR fixes the issue

@dubloom dubloom requested review from a team as code owners May 13, 2026 07:41
@dubloom dubloom requested review from avara1986 and emmettbutler May 13, 2026 07:41
@cit-pr-commenter-54b7da
Copy link
Copy Markdown

Codeowners resolved as

ddtrace/version.py                                                      @DataDog/python-guild @DataDog/apm-core-python

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: d0a2ab44c4

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread ddtrace/version.py
@dubloom dubloom added the changelog/no-changelog A changelog entry is not required for this PR. label May 13, 2026
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot merged commit 7ede72c into main May 13, 2026
340 checks passed
@gh-worker-dd-mergequeue-cf854d gh-worker-dd-mergequeue-cf854d Bot deleted the dubloom/fix-main-microbenchmmarks branch May 13, 2026 08:57
P403n1x87 pushed a commit that referenced this pull request May 14, 2026
## Description

This PR: #17964 broke main because it introduced code that is incompatible with python3.9. However, microbenchmarks are running on python3.9 which broke http microbenchmarks.

This PR fixes the issue 

Co-authored-by: louis.tricot <louis.tricot@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

changelog/no-changelog A changelog entry is not required for this PR.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants