-
Notifications
You must be signed in to change notification settings - Fork 394
experimental(contrib): add aws_lambda_ric
integration
#4767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-06-27 20:35:16 UTC |
Datadog ReportBranch report: ❌ 1 Failed (0 Known Flaky), 21737 Passed, 1293 Skipped, 5m 15.35s Total Time ❌ Failed Tests (1)
|
BenchmarksBenchmark execution time: 2025-07-30 04:15:15 Comparing candidate commit 4b9d63c in PR branch Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics. |
@duncanista if this PR is ready for review please fill out the template in the description, otherwise please mark it as draft |
|
||
# Store the arguments for later use in the trace | ||
@lambda_user_code_args = method(__method__).super_method.parameters.map do |type, name| | ||
[type, name, binding.local_variable_get(name)] if binding.local_variable_defined?(name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The customer code may mutate the parameters during execution (for example, if a parameter is a hash). Assuming you are intending to capture the input parameters, the easiest approach is to serialize them to json here.
also add import in `contrib.rb`
patches two methods so we can get `request`, `context`, and `response`
also `integration.rb` – just a rubocop fix
67d7f05
to
4b9d63c
Compare
|
What does this PR do?
Motivation:
Change log entry
Additional Notes:
How to test the change?