Skip to content

Conversation

duncanista
Copy link

What does this PR do?

Motivation:

Change log entry

Additional Notes:

How to test the change?

@duncanista duncanista requested a review from a team as a code owner June 27, 2025 20:35
Copy link

👋 Hey @DataDog/ruby-guild, please fill "Change log entry" section in the pull request description.

If changes need to be present in CHANGELOG.md you can state it this way

**Change log entry**

Yes. A brief summary to be placed into the CHANGELOG.md

(possible answers Yes/Yep/Yeah)

Or you can opt out like that

**Change log entry**

None.

(possible answers No/Nope/None)

Visited at: 2025-06-27 20:35:16 UTC

@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jun 27, 2025
@duncanista duncanista added do-not-merge/WIP Not ready for merge and removed integrations Involves tracing integrations tracing labels Jun 27, 2025
@github-actions github-actions bot added integrations Involves tracing integrations tracing labels Jun 27, 2025
@datadog-datadog-prod-us1
Copy link
Contributor

Datadog Report

Branch report: jordan.gonzalez/contrib/aws_lambda_ric
Commit report: 67d7f05
Test service: dd-trace-rb

❌ 1 Failed (0 Known Flaky), 21737 Passed, 1293 Skipped, 5m 15.35s Total Time

❌ Failed Tests (1)

  • Datadog::Tracing::Contrib ensures /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/aws_lambda_ric/integration.rb is loaded - rspec - Details

    Expand for error
     key not found: "aws_lambda_ric"
     
     Failure/Error: ruby_module = mapping.fetch(directory) # raise key error if not found
     
     KeyError:
       key not found: "aws_lambda_ric"
     ./spec/datadog/tracing/contrib_spec.rb:63:in 'Hash#fetch'
     ./spec/datadog/tracing/contrib_spec.rb:63:in 'block (4 levels) in <top (required)>'
     ./spec/spec_helper.rb:272:in 'block (2 levels) in <top (required)>'
     ./spec/spec_helper.rb:154:in 'block (2 levels) in <top (required)>'
     ...
    

@pr-commenter
Copy link

pr-commenter bot commented Jun 27, 2025

Benchmarks

Benchmark execution time: 2025-07-30 04:15:15

Comparing candidate commit 4b9d63c in PR branch jordan.gonzalez/contrib/aws_lambda_ric with baseline commit 6ee6fc8 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 44 metrics, 2 unstable metrics.

@p-datadog
Copy link
Member

@duncanista if this PR is ready for review please fill out the template in the description, otherwise please mark it as draft


# Store the arguments for later use in the trace
@lambda_user_code_args = method(__method__).super_method.parameters.map do |type, name|
[type, name, binding.local_variable_get(name)] if binding.local_variable_defined?(name)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The customer code may mutate the parameters during execution (for example, if a parameter is a hash). Assuming you are intending to capture the input parameters, the easiest approach is to serialize them to json here.

@duncanista duncanista marked this pull request as draft June 30, 2025 14:34
@duncanista duncanista force-pushed the jordan.gonzalez/contrib/aws_lambda_ric branch from 67d7f05 to 4b9d63c Compare July 30, 2025 03:45
@datadog-datadog-prod-us1
Copy link
Contributor

⚠️ Tests

⚠️ Warnings

🧪 1 Test failed

Datadog::Tracing::Contrib ensures /__w/dd-trace-rb/dd-trace-rb/lib/datadog/tracing/contrib/aws_lambda_ric/integration.rb is loaded from rspec (Datadog)
key not found: "aws_lambda_ric"

Failure/Error: ruby_module = mapping.fetch(directory) # raise key error if not found

KeyError:
  key not found: "aws_lambda_ric"
./spec/datadog/tracing/contrib_spec.rb:63:in \`block in <main>'
./spec/spec_helper.rb:272:in \`block in <main>'
./spec/spec_helper.rb:154:in \`block in <main>'
/usr/local/bundle/gems/webmock-3.13.0/lib/webmock/rspec.rb:37:in \`block in <main>'
...

ℹ️ Info

❄️ No new flaky tests detected

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: 4b9d63c | Docs | Was this helpful? Give us feedback!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
do-not-merge/WIP Not ready for merge integrations Involves tracing integrations tracing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants