[APMAPI-1607] Upgrade libdatadog dependency to version 22.0.1 #4902
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenchmarksBenchmark execution time: 2025-10-10 10:23:56 Comparing candidate commit 5023f8b in PR branch Found 3 performance improvements and 2 performance regressions! Performance is the same for 39 metrics, 2 unstable metrics. scenario:profiling - Allocations (baseline)
scenario:profiling - estimated profiler gc per minute (sample 60000 times + serialize result)
scenario:profiling - gvl benchmark samples
scenario:profiling - intern_all 1000 repeated strings
scenario:profiling - stack collector (varying depth)
|
vpellan
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
318b6ca to
9a1e91f
Compare
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 5023f8b | Docs | Was this helpful? Give us feedback! |
Did you mean libdatadog 21? |
Yes I didn't caught that, thanks ! |
p-datadog
previously approved these changes
Sep 25, 2025
vpellan
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
0f67946 to
d53a4e1
Compare
ericfirth
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
2 times, most recently
from
dd2edf2 to
ddaa7f7
Compare
ivoanjo
requested changes
Oct 1, 2025
There was a problem hiding this comment.
This PR had a bunch of things that surprised me...
I think the changes on install_datadog_deps.rb might've been trying to fix the issue I pointed out with the upstream libdatadog v21 package that's on rubygems.org, but that's the wrong place to fix them -- we need to respin that package, otherwise only SSI customers get the "fix", and all other customers don't.
I suspect that once we fix the libdatadog release, most (all?) changes in install_datadog_deps.rb can be reverted.
Because libdatadog v21.0.0.1.0 on rubygems is in bad shape, I'm marking this PR as "Request changes" as we mustn't merge it until the libdatadog release gets fixed. Otherwise our non-SSI customers would find the next dd-trace-rb release would suddenly be 10x as big as the previous one because of libdatadog.
There's a few more things I don't quite understand why they were changed, so I've left a few questions about them.
ericfirth
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
b9e113d to
898254a
Compare
p-datadog
dismissed
their stale review
The diff has grown considerably since my review
|
Are all of the changes in this PR required to be in one PR? 515f625 for example looks to be independent from "updating libdatadog dependency". |
ericfirth
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
898254a to
8b5d033
Compare
github-actions
bot
added
integrations
ericfirth
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
8b5d033 to
7ee0486
Compare
|
This PR also looks to have been incorrectly rebased. |
ericfirth
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
7ee0486 to
7465470
Compare
|
sorry about screwing up this branch. I removed all my changes and fixed the bad rebase |
vpellan
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
605bcd4 to
9ea74ba
Compare
vpellan
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
2 times, most recently
from
258293b to
0fa97b8
Compare
…d support for debug logs
libdatadog 22.0.0 introduced a breaking change in the process discovery FFI. This commit uses the new API.
Co-authored-by: Ivo Anjo <[email protected]>
vpellan
force-pushed
the
vpellan/update-stable-config-libdatadog-21
branch
from
0fa97b8 to
66c6015
Compare
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 840. Ignored filesNote: Ignored files are excluded from the next sections.
|
vpellan
changed the title
ivoanjo
approved these changes
Oct 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Updates the native bits in the gem (stable config, crashtracking) to be able to work with the latest libdatadog 22.0.1.
Motivation:
DSM needs libdatadog 22, and I had to update the native bits of stable config
Change log entry
Yes. Upgrade libdatadog dependency to 22.0.1
Additional Notes:
The branch name is off because it was originally supposed to be libdatadog 21, and only contains new stable config API but DSM and Process Discovery got added
How to test the change?
CI