-
Notifications
You must be signed in to change notification settings - Fork 394
Enable standard for integration apps #4937
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
👋 Hey @p-datadog, please fill "Change log entry" section in the pull request description. If changes need to be present in CHANGELOG.md you can state it this way **Change log entry**
Yes. A brief summary to be placed into the CHANGELOG.md (possible answers Yes/Yep/Yeah) Or you can opt out like that **Change log entry**
None. (possible answers No/Nope/None) Visited at: 2025-10-03 16:37:44 UTC |
TBH I think it's fine to enable for benchmarks, but for integration apps it doesn't seem particularly valuable? (But not a blocker for me, to clarify) |
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: 5eb5a08 | Docs | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I briefly look at the changes and I think it's fine. The only concern is that some DI test lines are changing which was unexpected.
22e8f89
to
5eb5a08
Compare
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 836. Ignored files
Note: Ignored files are excluded from the next sections.
|
No I ment that there was DI changes like adjustments in the code, beyond the style, which I find confusing. In the current state I don't see those changes anymore 👍🏼 |
What does this PR do?
Motivation:
Change log entry
Additional Notes:
How to test the change?