-
Notifications
You must be signed in to change notification settings - Fork 394
Add route serializers for Grape and Sinatra apps #4960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
BenchmarksBenchmark execution time: 2025-10-10 09:10:56 Comparing candidate commit d5395c8 in PR branch Found 3 performance improvements and 0 performance regressions! Performance is the same for 41 metrics, 2 unstable metrics. scenario:error - error tracking, with_error=false - third_party only
scenario:error - error tracking, with_error=false - user code only
scenario:profiling - intern_all 1000 repeated strings
|
d61271f
to
8ef2d85
Compare
Typing analysisIgnored filesThere are 539 ignored files in the Steepfile out of 840. Ignored files
Note: Ignored files are excluded from the next sections.
|
✅ Tests 🎉 All green!❄️ No new flaky tests detected 🎯 Code Coverage 🔗 Commit SHA: d5395c8 | Docs | Was this helpful? Give us feedback! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well done. I think separation of concerns could be improved to have a better encapsulation.
lib/datadog/appsec/api_security/endpoint_collection/rails_routes_serializer.rb
Outdated
Show resolved
Hide resolved
lib/datadog/appsec/api_security/endpoint_collection/rails_routes_serializer.rb
Outdated
Show resolved
Hide resolved
lib/datadog/appsec/api_security/endpoint_collection/rails_routes_serializer.rb
Outdated
Show resolved
Hide resolved
lib/datadog/appsec/api_security/endpoint_collection/rails_routes_serializer.rb
Outdated
Show resolved
Hide resolved
lib/datadog/appsec/api_security/endpoint_collection/sinatra_routes_serializer.rb
Outdated
Show resolved
Hide resolved
sig/datadog/appsec/api_security/endpoint_collection/grape_routes_serializer.rbs
Outdated
Show resolved
Hide resolved
sig/datadog/appsec/api_security/endpoint_collection/grape_routes_serializer.rbs
Outdated
Show resolved
Hide resolved
dd63766
to
e59fd44
Compare
e59fd44
to
e207805
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome 👏🏼
What does this PR do?
This PR adds endpoint collection for Grape and Sinatra applications that are embedded in a Rails app.
Motivation:
We want to report routes for embedded Grape APIs and embedded Sinatra apps within Rails.
Change log entry
None. This change is internal.
Additional Notes:
I had to add
grape
andsinatra
gems torails-app
appraisal for this.APPSEC-59518
How to test the change?
CI and app generator (generic rails app)