Remove ethon thread helper in test suite #5057
Merged
+9
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Strech
approved these changes
Nov 19, 2025
p-datadog
pushed a commit
that referenced
this pull request
Nov 20, 2025
…/telemetry-inject-deps' and 'u/telemetry-limit' into base * master: Remove ethon thread helper in test suite (#5057) [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/19513184798 (#5068) * u/flaky-di-test: [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/19513184798 (#5068) DI: make a test method longer to avoid flakiness * u/telemetry-inject-deps: Update lib/datadog/profiling/profiler.rb Update lib/datadog/profiling/profiler.rb * u/telemetry-limit: [🤖] Update System Tests: https://github.com/DataDog/dd-trace-rb/actions/runs/19513184798 (#5068)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Removes thread helper for ethon to silence thread leakage warnings.
There are no more warnings in master already, the helper is no longer needed.
Motivation:
Follow up to #5032
Change log entry
None
Additional Notes:
How to test the change?
I ran the changed tests locally and verified they produce no thread leak detector output.