Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update instrumentation_libraries.md #25596

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

tushar-datadog
Copy link
Contributor

What does this PR do? What is the motivation?

Merge instructions

  • Please merge after reviewing

Additional notes

@tushar-datadog tushar-datadog requested a review from a team as a code owner October 4, 2024 20:03
Copy link
Contributor

github-actions bot commented Oct 4, 2024

Preview links (active after the build_preview check completes)

Modified Files

@brett0000FF
Copy link
Contributor

@tushar-datadog - LGTM! Shoot me a ping when you want this merged. 🚀

Copy link
Contributor

@bm1549 bm1549 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM assuming this code compiles, runs, and produces correct output on your laptop

@@ -309,6 +349,52 @@ To use OpenTelemetry instrumentation libraries with the Datadog .NET SDK:
1. Set the `DD_TRACE_OTEL_ENABLED` environment variable to `true`.
2. Follow the steps to configure each library, if any, to generate OpenTelemetry-compatible instrumentation via `ActivitySource`

The following example demonstrates how to instrument the `Hangfire` OpenTelemetry integrations with the Datadog .NET SDK:

```js
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good point. You can use csharp.

The following example demonstrates how to instrument the `Hangfire` OpenTelemetry integrations with the Datadog .NET SDK:

```js
cusing System;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks like a typo

Suggested change
cusing System;
using System;

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants