-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update instrumentation_libraries.md #25596
base: master
Are you sure you want to change the base?
Conversation
Preview links (active after the
|
@tushar-datadog - LGTM! Shoot me a ping when you want this merged. 🚀 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM assuming this code compiles, runs, and produces correct output on your laptop
@@ -309,6 +349,52 @@ To use OpenTelemetry instrumentation libraries with the Datadog .NET SDK: | |||
1. Set the `DD_TRACE_OTEL_ENABLED` environment variable to `true`. | |||
2. Follow the steps to configure each library, if any, to generate OpenTelemetry-compatible instrumentation via `ActivitySource` | |||
|
|||
The following example demonstrates how to instrument the `Hangfire` OpenTelemetry integrations with the Datadog .NET SDK: | |||
|
|||
```js |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think GitHub supports C# highlighting
https://github.com/github-linguist/linguist/blob/main/lib/linguist/languages.yml
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point. You can use csharp
.
The following example demonstrates how to instrument the `Hangfire` OpenTelemetry integrations with the Datadog .NET SDK: | ||
|
||
```js | ||
cusing System; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks like a typo
cusing System; | |
using System; |
What does this PR do? What is the motivation?
Merge instructions
Additional notes