Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AI-4453] Add Milvus recommended monitors #19337

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

[AI-4453] Add Milvus recommended monitors #19337

wants to merge 2 commits into from
+78 −1

Conversation

dkirov-dd
Copy link
Contributor

What does this PR do?

Motivation

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@dkirov-dd dkirov-dd requested review from a team as code owners January 3, 2025 12:06
HadhemiDD
HadhemiDD previously approved these changes Jan 3, 2025
View reviewed changes
@codecov Codecov
Copy link

codecov bot commented Jan 3, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.43%. Comparing base (e794da6) to head (6266898).
Report is 1 commits behind head on master.

Additional details and impacted files
Flag Coverage Δ
activemq ?
cassandra ?
hive ?
hivemq ?
hudi ?
ignite ?
jboss_wildfly ?
kafka ?
presto ?
solr ?

Flags with carried forward coverage won't be shown. Click here to find out more.

hestonhoffman
hestonhoffman previously approved these changes Jan 3, 2025
View reviewed changes
Copy link
Contributor

@hestonhoffman hestonhoffman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tiny edit

milvus/assets/monitors/dml_channel_lag.json Outdated Show resolved Hide resolved
@dkirov-dd dkirov-dd dismissed stale reviews from hestonhoffman and HadhemiDD via 9938947 January 6, 2025 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@HadhemiDD HadhemiDD HadhemiDD left review comments

@hestonhoffman hestonhoffman hestonhoffman left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
agent/approved docs/approved ecosystems/review-requested product/review-requested
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dkirov-dd @hestonhoffman @HadhemiDD