-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI-5158] DDS: Microsoft DNS Agent Integration v1.0.0 #19986
base: master
Are you sure you want to change the base?
[AI-5158] DDS: Microsoft DNS Agent Integration v1.0.0 #19986
Conversation
Created DOCS-10536 for Docs Team editorial review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved, just needs a small change for the changelog filename!
.github/CODEOWNERS
Outdated
/microsoft_dns/ @DataDog/saas-integrations | ||
/microsoft_dns/*.md @DataDog/saas-integrations @DataDog/documentation | ||
/microsoft_dns/manifest.json @DataDog/saas-integrations @DataDog/documentation | ||
/microsoft_dns/assets/logs/ @DataDog/saas-integrations @DataDog/documentation @DataDog/logs-backend @DataDog/logs-core |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you change the owner @DataDog/agent-integrations?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have updated the owners to @DataDog/agent-integrations
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm I still see @DataDog/saas-integrations.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review from nubtron is dismissed. Related teams and files:
- agent-integrations
- .github/CODEOWNERS
- microsoft_dns/changelog.d/19986.added
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @mauneelsorathia-crest Just a few suggestions for wording and there is an image_url
that needs fixed in the microsoft_dns_overview.json
, thanks!
Co-authored-by: Alicia Scott <[email protected]>
Co-authored-by: Alicia Scott <[email protected]>
Co-authored-by: Alicia Scott <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the changes and fixing the image!
What does this PR do?
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged