Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-5158] DDS: Microsoft DNS Agent Integration v1.0.0 #19986

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

mauneelsorathia-crest
Copy link
Contributor

What does this PR do?

  • This is an initial release PR of Microsoft DNS integration including all the required assets. This is agent based integration.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@mauneelsorathia-crest mauneelsorathia-crest marked this pull request as ready for review April 2, 2025 11:33
@mauneelsorathia-crest mauneelsorathia-crest requested review from a team as code owners April 2, 2025 11:33
@mauneelsorathia-crest mauneelsorathia-crest changed the title DDS: Microsoft DNS Agent Integration v1.0.0 [AI-5158] DDS: Microsoft DNS Agent Integration v1.0.0 Apr 2, 2025
@drichards-87 drichards-87 added the editorial review Waiting on a more in-depth review from a docs team editor label Apr 2, 2025
@drichards-87
Copy link
Contributor

Created DOCS-10536 for Docs Team editorial review.

nubtron
nubtron previously approved these changes Apr 3, 2025
Copy link
Contributor

@nubtron nubtron left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, just needs a small change for the changelog filename!

/microsoft_dns/ @DataDog/saas-integrations
/microsoft_dns/*.md @DataDog/saas-integrations @DataDog/documentation
/microsoft_dns/manifest.json @DataDog/saas-integrations @DataDog/documentation
/microsoft_dns/assets/logs/ @DataDog/saas-integrations @DataDog/documentation @DataDog/logs-backend @DataDog/logs-core
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you change the owner @DataDog/agent-integrations?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have updated the owners to @DataDog/agent-integrations.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm I still see @DataDog/saas-integrations.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You might be viewing the outdated one. Here is the commit link for reference. Can you please try opening this?

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed nubtron’s stale review April 4, 2025 06:05

Review from nubtron is dismissed. Related teams and files:

  • agent-integrations
    • .github/CODEOWNERS
    • microsoft_dns/changelog.d/19986.added
Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mauneelsorathia-crest Just a few suggestions for wording and there is an image_url that needs fixed in the microsoft_dns_overview.json, thanks!

Copy link
Contributor

@aliciascott aliciascott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the changes and fixing the image!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants