Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[AI-5206] DDS: WatchGuard Firebox Integration v1.0.0 #20030

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

manan-crest
Copy link
Contributor

What does this PR do?

PR for a new integration WatchGuard Integration 1.0.0

Additional Notes

-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.

Review checklist (to be filled by reviewers)

  • Feature or bugfix MUST have appropriate tests (unit, integration, e2e)
  • Add the qa/skip-qa label if the PR doesn't need to be tested during QA.
  • If you need to backport this PR to another branch, you can add the backport/<branch-name> label to the PR and it will automatically open a backport PR once this one is merged

@manan-crest manan-crest marked this pull request as ready for review April 9, 2025 14:13
@manan-crest manan-crest requested review from a team as code owners April 9, 2025 14:13
@manan-crest manan-crest changed the title DDS: WatchGuard Firebox Integration v1.0.0 [AI-5206] DDS: WatchGuard Firebox Integration v1.0.0 Apr 9, 2025
@buraizu buraizu added the editorial review Waiting on a more in-depth review from a docs team editor label Apr 9, 2025
@buraizu
Copy link
Contributor

buraizu commented Apr 9, 2025

Created DOCS-10585 for documentation team review

NouemanKHAL
NouemanKHAL previously approved these changes Apr 10, 2025
@NouemanKHAL
Copy link
Member

I think the CODEOWNERS file should be updated to reflect the ownership of this integration.

@temporal-github-worker-1 temporal-github-worker-1 bot dismissed NouemanKHAL’s stale review April 11, 2025 10:32

Review from NouemanKHAL is dismissed. Related teams and files:

  • agent-integrations
    • .github/CODEOWNERS
@manan-crest
Copy link
Contributor Author

I think the CODEOWNERS file should be updated to reflect the ownership of this integration.

We have updated CODEOWNERS file.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants