-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AI-5206] DDS: WatchGuard Firebox Integration v1.0.0 #20030
Open
manan-crest
wants to merge
10
commits into
DataDog:master
Choose a base branch
from
bhargavnariyanicrest:watchguard-firebox-v1.0.0
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
[AI-5206] DDS: WatchGuard Firebox Integration v1.0.0 #20030
manan-crest
wants to merge
10
commits into
DataDog:master
from
bhargavnariyanicrest:watchguard-firebox-v1.0.0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Created DOCS-10585 for documentation team review |
NouemanKHAL
previously approved these changes
Apr 10, 2025
I think the CODEOWNERS file should be updated to reflect the ownership of this integration. |
Review from NouemanKHAL is dismissed. Related teams and files:
- agent-integrations
- .github/CODEOWNERS
We have updated CODEOWNERS file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
agent/review-requested
dev/testing
dev/tooling
docs/review-requested
documentation
ecosystems/review-requested
editorial review
Waiting on a more in-depth review from a docs team editor
product/review-requested
qa/skip-qa
Automatically skip this PR for the next QA
release
team/agent-integrations
team/documentation
team/logs-backend
team/logs-integrations-reviewers
team/saas-integrations
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
PR for a new integration WatchGuard Integration 1.0.0
Additional Notes
-- OOTB detection rules JSON would be shared separately with the required teams as a part of separate repository .
-- Since during the standard attribute remapping we are not preserving the source attributes as per suggested best practices, it would result in filters using these standard attributes populating the values of other integrations as well as per current datadog behavior.
Review checklist (to be filled by reviewers)
qa/skip-qa
label if the PR doesn't need to be tested during QA.backport/<branch-name>
label to the PR and it will automatically open a backport PR once this one is merged