Isolate tower to single use site #1192
Open
+2
−16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit removes the `tower` crate down into sheepdog where it has its last remaining use. We do require it here as it's Service is part of the type defintion for our UDS connection function. Signed-off-by: Brian L. Troutwine <[email protected]>
GeorgeHahn
reviewed
Dec 31, 2024
| "load-shed", | ||
| "util" | ||
| ] } | ||
| tower = { version = "0.5", default-features = false, features = ["util"] } |
There was a problem hiding this comment.
This could maybe be reduced to only https://docs.rs/tower-service/0.3.3/tower_service/
There was a problem hiding this comment.
Oh you know, good point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This commit removes the
towercrate down into sheepdog where ithas its last remaining use. We do require it here as it's Service
is part of the type definition for our UDS connection function.