Skip to content

Upgrade actions/checkout version to fix CI #22

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
May 1, 2025
Merged

Upgrade actions/checkout version to fix CI #22

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
2eee170
Upgrade actions/checkout version to fix CI
christophetd May 1, 2025
ae0b8db
Upgrade staticcheck-action and staticcheck version in CI
christophetd May 1, 2025
c83c73b
Use a less cutting-edge version of staticcheck for CI
christophetd May 1, 2025
c26915c
use go 1.23 in CI for staticcheck
christophetd May 1, 2025
c840deb
Use buffered signal for calling os.Notify
christophetd May 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/static-analysis.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,14 @@ jobs:
name: "Run Go static analysis"
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v1
- uses: actions/checkout@v4
with:
fetch-depth: 1
- name: Set up Go
uses: actions/setup-go@v2
with:
go-version: 1.18
- uses: dominikh/staticcheck-action@v1.2.0
go-version: 1.23
- uses: dominikh/staticcheck-action@v1.3.1
with:
version: "2022.1"
version: "2024.1"
install-go: false
13 changes: 7 additions & 6 deletions pkg/managed-kubernetes-auditing-toolkit/eks/imds/imds_tester.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,16 +5,17 @@ import (
"context"
"fmt"
"io"
v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/kubernetes"
typedv1 "k8s.io/client-go/kubernetes/typed/core/v1"
"os"
"os/signal"
"strings"
"syscall"
"time"

v1 "k8s.io/api/core/v1"
metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/util/wait"
"k8s.io/client-go/kubernetes"
typedv1 "k8s.io/client-go/kubernetes/typed/core/v1"
)

type ImdsTester struct {
Expand Down Expand Up @@ -131,7 +132,7 @@ func (m *ImdsTester) runCommandInPodAndGetLogs(podName string, command []string)

func (m *ImdsTester) handleCtrlC() {
// If the user interactively cancels the test, clean up the pod
c := make(chan os.Signal)
c := make(chan os.Signal, 1)
signal.Notify(c, os.Interrupt, syscall.SIGTERM)
go func() {
<-c
Expand Down