Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for OTel Python runtime metrics #114

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

liustanley
Copy link
Contributor

What does this PR do?

Adds mappings and prefixes for OTel Python runtime metrics. The v2 DD Python names are still undecided, so the DD prefixes in the mappings will change before merging.

Motivation

@liustanley liustanley requested a review from a team as a code owner June 28, 2023 17:44
@liustanley liustanley requested a review from mx-psi June 28, 2023 17:44
@mx-psi mx-psi requested a review from majorgreys June 28, 2023 19:46
@mx-psi
Copy link
Member

mx-psi commented Jun 29, 2023

The v2 DD Python names are still undecided, so the DD prefixes in the mappings will change before merging.

Should we mark this as draft then until this is decided? Or is this ready for review now?

@liustanley
Copy link
Contributor Author

The v2 DD Python names are still undecided, so the DD prefixes in the mappings will change before merging.

Should we mark this as draft then until this is decided? Or is this ready for review now?

This can be reviewed now, the only thing that will change are the metric names and I won't merge before updating them.

Copy link
Member

@mx-psi mx-psi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM save for the metric names. Will actually approve once the names are ready!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants