Add support for feature dependencies. #136
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bruceg
reviewed
Apr 25, 2024
| @@ -4,7 +4,7 @@ description = "A tool for creating the `LICENSE-3rdparty.csv` file for DataDog o | |||
| homepage = "https://github.com/DataDog/rust-license-tool" | |||
| repository = "https://github.com/DataDog/rust-license-tool" | |||
| readme = "README.md" | |||
| version = "1.0.3" | |||
| version = "1.1.0" | |||
There was a problem hiding this comment.
I think I'd prefer to handle the version bump in a separate PR.
| Additionally you can pass the the following arguments to get the licenses for optional dependencies | ||
| behind features: | ||
|
|
||
| * `--features []`, `-f []`: comma separated list of features. |
There was a problem hiding this comment.
Could we put a meta-var in place of [] here? For example:
Suggested change
| * `--features []`, `-f []`: comma separated list of features. | |
| * `--features`, `-f FEATURE[,FEATURE...]`: comma separated list of features. |
Comment on lines
+68
to
+72
| #[arg(short, long)] | ||
| features: Vec<String>, | ||
|
|
||
| #[arg(long)] | ||
| all_features: bool, |
There was a problem hiding this comment.
Would there be value in also having a --no-default-features the same as other cargo commands with features?
Should these should go before config above, or does that produce an unnatural ordering in the command-line help? They could use a short doc comment for that in any case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From a Slack discussion: