Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

akka-http and play appsec support #1753

Merged
merged 1 commit into from
Oct 29, 2023
Merged

akka-http and play appsec support #1753

merged 1 commit into from
Oct 29, 2023

Conversation

cataphract
Copy link
Contributor

Description

Add support for appsec in akka-http and add a Play application. Support for appsec is to be available on both since v1.22.0.

Workflow

  1. ⚠️⚠️ Create your PR as draft
  2. Follow the style guidelines of this project (See how to easily lint the code)
  3. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  4. Mark it as ready for review

Once your PR is reviewed, you can merge it! ❤️

Reviewer checklist

  • Check what scenarios are modified. If needed, add the relevant label (run-parametric-scenario, run-profiling-scenario...). If this PR modifies any system-tests internal, then add the run-all-scenarios label (more info).
  • CI is green
    • If not, failing jobs are not related to this change (and you are 100% sure about this statement)
  • if any of build-some-image label is present
    1. is the image labl have been updated ?
    2. just before merging, locally build and push the image to hub.docker.com
  • if a scenario is added (or removed), add (or remove) it in system-test-dasboard nightly

@cataphract cataphract added java Pull requests that update Java code run-appsec-scenarios labels Oct 26, 2023
@cataphract cataphract mentioned this pull request Oct 26, 2023
Closed
5 tasks
@cataphract cataphract marked this pull request as ready for review October 27, 2023 07:02
@cataphract cataphract requested review from a team as code owners October 27, 2023 07:02
@cataphract
Copy link
Contributor Author

Failure in play/dev should have been solved by the merging of DataDog/dd-trace-java#6100

@robertomonteromiguel
Copy link
Collaborator

Failure in play/dev should have been solved by the merging of DataDog/dd-trace-java#6100

https://github.com/DataDog/system-tests/blob/main/docs/edit/egg-chicken-changes.md

robertomonteromiguel
robertomonteromiguel requested changes Oct 27, 2023
View reviewed changes
Copy link
Collaborator

@robertomonteromiguel robertomonteromiguel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Merge dd-trace-java before merge this PR

@cataphract cataphract merged commit cffea93 into main Oct 29, 2023
289 of 342 checks passed
@cataphract cataphract deleted the glopes/play-akka-appsec branch October 29, 2023 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@robertomonteromiguel robertomonteromiguel robertomonteromiguel approved these changes

@anderruiz anderruiz Awaiting requested review from anderruiz anderruiz is a code owner automatically assigned from DataDog/asm-java

@bantonsson bantonsson Awaiting requested review from bantonsson bantonsson is a code owner automatically assigned from DataDog/apm-java

@nayeem-kamal nayeem-kamal Awaiting requested review from nayeem-kamal nayeem-kamal is a code owner automatically assigned from DataDog/apm-java

Assignees
No one assigned
Labels
java Pull requests that update Java code run-all-scenarios run-appsec-scenarios
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cataphract @robertomonteromiguel