Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

parametric: replace span kind and status code constants with enums #3370

Merged
merged 12 commits into from
Nov 13, 2024
Merged

parametric: replace span kind and status code constants with enums #3370

merged 12 commits into from
Nov 13, 2024
+115 −76

Conversation

mabdinur
Copy link
Contributor

@mabdinur mabdinur commented Nov 4, 2024 •
edited
Loading

Changes

Replaces sets of constants with Enums. This will improve the readability and paintability of parametric tests.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mabdinur mabdinur force-pushed the munir/create-enums-for-groups-of-constants-parametric branch from 7960fa7 to b61237a Compare November 11, 2024 20:31
@mabdinur mabdinur changed the title parametric: use a constant for span kind and status code [WIP] parametric: replace span kind and status code constants with enums Nov 12, 2024
@mabdinur mabdinur marked this pull request as ready for review November 12, 2024 01:17
@mabdinur mabdinur requested review from a team as code owners November 12, 2024 01:17
@mabdinur mabdinur requested review from rachelyangdog and removed request for a team November 12, 2024 01:17
cbeauchesne
cbeauchesne requested changes Nov 12, 2024
View reviewed changes
tests/parametric/test_otel_span_methods.py Outdated
("client.request", SpanKind.CLIENT, None),
("internal", SpanKind.INTERNAL, None),
("consumer", SpanKind.CONSUMER, None),
("producer", SpanKind.PRODUCER, None),
("internal", None, None),
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line sends None as SpanKind, and then fails

@mabdinur mabdinur merged commit 9baa358 into main Nov 13, 2024
463 of 467 checks passed
@mabdinur mabdinur deleted the munir/create-enums-for-groups-of-constants-parametric branch November 13, 2024 21:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbeauchesne cbeauchesne cbeauchesne approved these changes

@rachelyangdog rachelyangdog Awaiting requested review from rachelyangdog rachelyangdog is a code owner automatically assigned from DataDog/apm-sdk-api

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mabdinur @cbeauchesne