adding mypy to parametric tests #3405
Open
+122
−73
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mabdinur
reviewed
Nov 7, 2024
cbeauchesne
requested changes
Nov 8, 2024
cbeauchesne
requested changes
Nov 14, 2024
| @@ -102,6 +102,12 @@ allow_no_jira_ticket_for_bugs = [ | |||
| "tests/parametric/test_config_consistency.py::Test_Config_TraceLogDirectory", | |||
| ] | |||
|
|
|||
| [tool.mypy] | |||
| files = ["utils/parametric", "tests/parametric"] | |||
There was a problem hiding this comment.
To perform a proper migration to this tools, could you revert any change that are not in those two folders ?
| @@ -257,13 +261,14 @@ def _build_apm_test_server_image(self) -> str: | |||
| check=False, | |||
| ) | |||
|
|
|||
| failure_text: str = None | |||
| failure_text: Optional[str] = None | |||
There was a problem hiding this comment.
This line can be removed, as the variable is used only in the if block
| @@ -205,7 +205,7 @@ def library(self): | |||
| def weblog_variant(self): | |||
| return f"parametric-{self.library.library}" | |||
|
|
|||
| def _build_apm_test_server_image(self) -> str: | |||
| def _build_apm_test_server_image(self) -> Optional[str]: | |||
There was a problem hiding this comment.
If I'm not wrong, this function always return None
| if p.returncode != 0: | ||
| log_file.seek(0) | ||
| failure_text = "".join(log_file.readlines()) | ||
| pytest.exit(f"Failed to build the container: {failure_text}", 1) | ||
|
|
||
| logger.debug("Build tested container finished") | ||
| return None |
There was a problem hiding this comment.
Does mypy requires to explicitly return None ?
| @@ -77,8 +77,8 @@ class V06StatsAggr(TypedDict): | |||
| TopLevelHits: int | |||
| Duration: int | |||
| Errors: int | |||
| OkSummary: BaseDDSketch | |||
| ErrorSummary: BaseDDSketch | |||
| OkSummary: Optional[BaseDDSketch] | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Update the ./format.sh script to run static analysis checks on parametric tests (via mypy).
Changes
Updated mypy and fixed all errors. (as of now a lot of fixes are # type: ignore)
Workflow
codeownersfile quickly.🚀 Once your PR is reviewed, you can merge it!
🛟 #apm-shared-testing 🛟
Reviewer checklist
[<language>], double-check that only<language>is impacted by the changebuild-XXX-imagelabel is present