Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a test for esm #3429

Merged
merged 3 commits into from
Nov 13, 2024
Merged

add a test for esm #3429

merged 3 commits into from
Nov 13, 2024

Conversation

rochdev
Copy link
Member

@rochdev rochdev commented Nov 11, 2024

Motivation

ESM is currently not working properly, so we need to first add a test and make it pass.

Changes

Add a test for ESM and skip it for now.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@rochdev rochdev marked this pull request as ready for review November 11, 2024 22:22
@rochdev rochdev requested a review from a team as a code owner November 11, 2024 22:22
@rochdev rochdev marked this pull request as draft November 12, 2024 04:33
@rochdev rochdev marked this pull request as ready for review November 12, 2024 19:58
@rochdev rochdev changed the title add a test that esm is currently not working add a test for esm Nov 12, 2024
@rochdev rochdev merged commit 3820f6a into main Nov 13, 2024
464 of 467 checks passed
@rochdev rochdev deleted the rochdev/nodejs-esm-ssi-test branch November 13, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants