Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "OnBoarding: Force full tracing without limits" #3443

Conversation

raphaelgavache
Copy link
Member

Reverts #3432 as its failing python injection tests, the syntax needs to be changed

raphael_gavache_datadoghq_com@raphael-debian12:~$ DD_APM_INSTRUMENTATION_DEBUG=true DD_TRACE_DEBUG=true DD_TRACE_SAMPLING_RULES=[{'sample_rate':1}]  python3
...
[2024-11-12 16:36:04] [ERROR] datadog.autoinstrumentation(pid: 943923): failed to load ddtrace module: cannot access local variable 'json_rules' where it is not associated with a value

raphael_gavache_datadoghq_com@raphael-debian12:~$ DD_APM_INSTRUMENTATION_DEBUG=true DD_TRACE_DEBUG=true DD_TRACE_SAMPLING_RULES="[{'sample_rate':1}]"  python3
...
[2024-11-12 16:36:04] [ERROR] datadog.autoinstrumentation(pid: 943923): failed to load ddtrace module: cannot access local variable 'json_rules' where it is not associated with a value

@raphaelgavache raphaelgavache requested a review from a team as a code owner November 12, 2024 16:38
@raphaelgavache raphaelgavache merged commit e2e4acd into main Nov 12, 2024
13 of 14 checks passed
@raphaelgavache raphaelgavache deleted the revert-3432-robertomonteromiguel/onboarding_force_tracing_without_limits branch November 12, 2024 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants