Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[golang] Remove install script from parametric app's dockerfile #3444

Closed
wants to merge 2 commits into from

Conversation

mtoffl01
Copy link
Contributor

@mtoffl01 mtoffl01 commented Nov 12, 2024

Motivation

We've previously updated the parametric app instructions to say, "just run go get with the specific library version you'd like to run the tests with," and yet the Dockerfile would install a conflicting version, effectively blocking us from using a non-default version of dd-trace-go in parametric tests.

Changes

This PR removes that install script from the Dockerfile.

Workflow

  1. ⚠️ Create your PR as draft ⚠️
  2. Work on you PR until the CI passes (if something not related to your task is failing, you can ignore it)
  3. Mark it as ready for review
    • Test logic is modified? -> Get a review from RFC owner. We're working on refining the codeowners file quickly.
    • Framework is modified, or non obvious usage of it -> get a review from R&P team

🚀 Once your PR is reviewed, you can merge it!

🛟 #apm-shared-testing 🛟

Reviewer checklist

  • If PR title starts with [<language>], double-check that only <language> is impacted by the change
  • No system-tests internal is modified. Otherwise, I have the approval from R&P team
  • CI is green, or failing jobs are not related to this change (and you are 100% sure about this statement)
  • A docker base image is modified?
    • the relevant build-XXX-image label is present
  • A scenario is added (or removed)?

@mtoffl01 mtoffl01 requested review from a team as code owners November 12, 2024 21:07
@mtoffl01 mtoffl01 marked this pull request as draft November 12, 2024 21:10
@mtoffl01 mtoffl01 closed this Nov 13, 2024
@mtoffl01 mtoffl01 deleted the mtoff/fix-parametric-go-get branch November 13, 2024 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant