Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve README around site #3

Merged
merged 1 commit into from
Jul 18, 2024
Merged

Improve README around site #3

merged 1 commit into from
Jul 18, 2024

Conversation

juan-fernandez
Copy link
Contributor

What does this PR do?

Improve instructions around site. US1 is not a valid DD_SITE parameter, and we use inputs.site directly to pass to DD_SITE:

test-visibility-github-action/action.yml

Line 67 in 8cea2a0

echo "DD_SITE=${{ inputs.site }}" >> "$GITHUB_ENV"

Motivation

Reduce likelihood of invalid config

Describe how to test/QA your changes

Check if it makes sense

@juan-fernandez juan-fernandez requested a review from a team as a code owner July 18, 2024 07:42
@nikita-tkachenko-datadog nikita-tkachenko-datadog merged commit a21ebb4 into main Jul 18, 2024
1 of 2 checks passed
@juan-fernandez juan-fernandez deleted the juan-fernandez/improve-site-info branch July 18, 2024 08:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nikita-tkachenko-datadog nikita-tkachenko-datadog nikita-tkachenko-datadog approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juan-fernandez @nikita-tkachenko-datadog