TG 839 #38
TG 839 #38
Conversation
Co-authored-by: rboni-dk <[email protected]>
dk-installer.py
Outdated
| os.makedirs(data_folder, exist_ok=True) | ||
| else: | ||
| script_path = pathlib.Path(sys.argv[0]).absolute() | ||
| data_folder = script_path.parent.joinpath("DataKitchenApps") |
There was a problem hiding this comment.
This will change the folder name on Linux, etc. Is this expected?
dk-installer.py
Outdated
| if args.skip_verify: | ||
| return | ||
|
|
There was a problem hiding this comment.
Sorry, I don't remember if I've asked this before, but why are we removing the --skip-verify option?
dk-installer.py
Outdated
| if detect_os() == 'Windows': | ||
| self.docker_compose_file = get_docker_compose_path() | ||
| else: | ||
| self.docker_compose_file = pathlib.Path() / DOCKER_COMPOSE_FILE |
There was a problem hiding this comment.
This is confusing. Isn't the get_docker_compose_path() handling this?
|
|
||
|
|
||
| class TestGenSetupDatabaseStep(Step): | ||
| label = "Initializing the platform database" | ||
| required = False |
There was a problem hiding this comment.
@FernandezAstor , why are we changing this to False?
There was a problem hiding this comment.
It was part of the oldest PR:
https://github.com/DataKitchen/data-observability-installer/pull/35/files
There was a problem hiding this comment.
Oh, I see.. Wait.. you were adding the timeout to the network removal, right? What happened to that?
There was a problem hiding this comment.
yes, but Aarthy told me to leave it as it was originally.
No description provided.