Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TG 839 #38

Open
wants to merge 5 commits into
base: main
Choose a base branch
from
Open

TG 839 #38

wants to merge 5 commits into from

Conversation

FernandezAstor
Copy link
Contributor

No description provided.

dk-installer.py Outdated
os.makedirs(data_folder, exist_ok=True)
else:
script_path = pathlib.Path(sys.argv[0]).absolute()
data_folder = script_path.parent.joinpath("DataKitchenApps")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will change the folder name on Linux, etc. Is this expected?

dk-installer.py Outdated
Comment on lines 1236 to 1238
if args.skip_verify:
return

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I don't remember if I've asked this before, but why are we removing the --skip-verify option?

dk-installer.py Outdated
Comment on lines 1625 to 1628
if detect_os() == 'Windows':
self.docker_compose_file = get_docker_compose_path()
else:
self.docker_compose_file = pathlib.Path() / DOCKER_COMPOSE_FILE
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is confusing. Isn't the get_docker_compose_path() handling this?



class TestGenSetupDatabaseStep(Step):
label = "Initializing the platform database"
required = False
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@FernandezAstor , why are we changing this to False?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I see.. Wait.. you were adding the timeout to the network removal, right? What happened to that?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, but Aarthy told me to leave it as it was originally.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants