[Improvement] Optimize selection prompt information when querying in yarn application mode; Added Run button to check select execute #3260
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…yarn application mode; Added Run button to check select
…yarn application mode; Added Run button to check select
github-actions
bot
requested review from
aiwenmo,
gaoyan1998,
zackyoungh and
Zzm0809
Zzm0809
reviewed
Mar 8, 2024
dinky-admin/src/main/java/org/dinky/service/impl/TaskServiceImpl.java
Outdated
Show resolved
Hide resolved
Closed
3 tasks
|
需要补充一下 en 的国际化 |
|
mvn spotless:apply |
|
useful pr! |
gaoyan1998
pushed a commit
to gaoyan1998/dinky
that referenced
this pull request
Mar 19, 2024
…yarn application mode; Added Run button to check select execute (DataLinkDC#3260) Co-authored-by: 173lyb <[email protected]>
leechor
pushed a commit
that referenced
this pull request
Jul 17, 2024
…yarn application mode; Added Run button to check select execute (#3260) Co-authored-by: 173lyb <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
#3237
针对于select场景做了校验：
[查询]按钮不支持 yarn cluster模式和k8s cluster模式
[运行]按钮执行时对select 语句的异常做了提示：
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows: