Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
by doing some lightweight string manipulation for our custom statements and otherwise using Flink entirely for parsing and planning.
This has the potential to eliminate a lot of code (parser and Sqrl2Flink translation) while making it easier to remain compatible with Flink.
It also allows us to move to FLinkSQL for connector configuration to replace our table.json files.
Open questions:
To Dos:
[] inject SqrlLogicalPlanRewriter into the ViewConverter and keep track of metadata.
[] support CREATE TABLE for mutations
[] make the lightweight statement parser more robust using SqlIdentifier and ideally some real parsing instead of regex