Resolve Test Error Logging and Repair Broken Integration Tests #920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Zesky665
approved these changes
Oct 18, 2024
|
Break color formatting? Maybe we can log twice, once for the logger and once at the end for the user. Also why is the analytics case flakey? |
henneberger
reviewed
Nov 1, 2024
| exitCode = 1; | ||
| } else if (e instanceof MissingSnapshotException) { | ||
| MissingSnapshotException ex = (MissingSnapshotException) e; | ||
| logRed("Snapshot on filesystem but not in result: " + ex.getTestName()); |
There was a problem hiding this comment.
This appears to break our color formatting. This is really helpful to see. We spoke about maybe logging twice so it can be easier to find in the build logs, where we could log when we observe a test failure and the produce a color summary at the end.
This reverts commit 2db643d.
nandorsoma
force-pushed
the
904-resolve-test-error-logging-and-repair-broken-integration-tests
branch
from
60fdcd9 to
edd4db9
Compare
|
What is this PR solving? Is there an issue attached to this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.