Moving logic with a graph to a separate library in NPM. #939
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mbroecheler
requested changes
Nov 1, 2024
| }); | ||
|
|
||
| const edges = elements.flatMap((node) => |
There was a problem hiding this comment.
Can we move the transformation from elements to nodes and edges into the renderGraph method?
| @@ -1,163 +1,30 @@ | |||
| <!DOCTYPE html> | |||
| <html> | |||
| <head> | |||
| <head> | |||
| <title>Visualize DAG with Cytoscape.js</title> | |||
There was a problem hiding this comment.
Could you please rename this to "DataSQRL Deployment Graph Visualization"
|
This looks good. This PR is ready to be merged once we have made the changes I slacked you in the visualization library. Let's keep this open until then. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The page has been moved to a separate library and rewritten in TypeScript for ease of further development and support, as it is used in both the sqrl repository and the client-frontend repository.
Source code repository - https://github.com/DataSQRL/dag-visualization/
NPM package page - https://www.npmjs.com/package/@datasqrl/dag-visualization
Compiled code - https://www.unpkg.com/browse/@datasqrl/dag-visualization@latest/