Skip to content

Raise requirement to PHP 8.1, test on PHP 8.4 #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 23, 2025
Merged

Raise requirement to PHP 8.1, test on PHP 8.4 #238

merged 6 commits into from
Sep 23, 2025

Conversation

reedy
Copy link
Contributor

@reedy reedy commented Sep 23, 2025

Fixes #235

@reedy reedy mentioned this pull request Sep 23, 2025
Closed
@reedy reedy changed the title Raise requirement to PHP 8.1 Raise requirement to PHP 8.1, test on PHP 8.4 Sep 23, 2025
@reedy reedy force-pushed the php81 branch 9 times, most recently from 8c904f4 to 8e40786 Compare September 23, 2025 16:11
@reedy reedy force-pushed the php81 branch 2 times, most recently from b551c87 to 346f50d Compare September 23, 2025 16:24
@reedy
Copy link
Contributor Author

reedy commented Sep 23, 2025

Not completely sure if we really want to add the @api or just mark a load of stuff final...

But this gets testing on PHP 8.4 etc unblocked, and things could be tidied up before the next release

Consumes #224, and replaces #225

@reedy reedy mentioned this pull request Sep 23, 2025
Closed
@JeroenDeDauw JeroenDeDauw merged commit 6928146 into DataValues:master Sep 23, 2025
4 checks passed
@reedy reedy deleted the php81 branch September 23, 2025 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bump required PHP version to >= 8.1 and drop symfony/polyfill-php80
2 participants
@reedy @JeroenDeDauw