-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
implement unselectable features #197
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I configure featureList
, non-selectable features are still selectable. Thus, they also change their styling if bindWithCoreHoverSelect
is used.
I would have expected that features that not selectable in the map are not being shown in the featureList
. Would you agree?
Edit: Meldemichel seems to be working fine as far as I can tell.
apply suggestion "remove misplaced word" Co-authored-by: Pascal Röhling <[email protected]>
Yes, I agree. As discussed before, I'm shoveling the PR over to you and added you as assignee. Should any question about my implementation so far arise, call me anytime. |
I've fixed that behaviour in c38065c. |
🚀 @dopenguin Checked and just works. Nice. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I configure
featureList
, non-selectable features are still selectable. Thus, they also change their styling ifbindWithCoreHoverSelect
is used. I would have expected that features that not selectable in the map are not being shown in thefeatureList
. Would you agree?
🏓 @warm-coolguyYes, I agree. As discussed before, I'm shoveling the PR over to you and added you as assignee. Should any question about my implementation so far arise, call me anytime.
🏓 @dopenguinI've fixed that behaviour in c38065c. If you want to reproduce it, I've attached a patch with the relevant changes to
@polar/client-snowbox
.
🏓 @warm-coolguy🚀 @dopenguin Checked and just works. Nice.
🚀 @warm-coolguy weeeee
Summary
extendedMasterportalapiMarkers
in the core, the feature has been doubled; since it is orthogonal to GFI, two configurations are required to get the feature running in this mode, one on the markers, one in the GFI. However, styling has been resolved here, as it is internal to this feature.Instructions for local reproduction and review
Use the snowbox to check the behaviour. Use cases have been added.
extendedMasterportalapiMarkers
: Switch the "Reports (MML)" layer on. Arbitrarily, features with uneven ID have been deemed unselectable. Check whether the behaviour seems plausible/correct to you.You may also test GFI on the GeoJSON layer by removing the
extendedMasterportalapiMarkers
andenableClustering
related code. In that case, all pins are visible, but only pins with even number display a GFI window. As in the first case, styling will have to be added later on the layer itself.Also, please confirm that nothing in the Meldemichel broke.