feat(plugins/geoLocation): migrate plugin #366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
warm-coolguy
changed the base branch from
next
to
vue3/migrate-plugin-icon-menu
dopenguin
added
enhancement
dopenguin
added a commit
that referenced
this pull request
Oct 21, 2025
dopenguin
added a commit
that referenced
this pull request
Oct 21, 2025
This was referenced Oct 21, 2025
# Conflicts: # eslint.config.ts # examples/snowbox/index.js # package-lock.json # src/components/PolarIconButton.ce.vue # src/core/stores/main.ts # src/core/types/plugin.ts # src/lib/notifyUser.ts # src/lib/passesBoundaryCheck.ts # src/lib/tooltip.ts # src/plugins/fullscreen/components/FullscreenUI.ce.vue
# Conflicts: # examples/snowbox/index.js
…the user is not locatable
…it will later on be added
Are not executed yet as the problem with the usage of useCoreStore still persists.
… independently with nineRegions
dopenguin
requested review from
dopenguin and
oeninghe-dataport
as code owners
dopenguin
changed the title
…3/migration-plugin-geo-location
…3/migration-plugin-geo-location
dopenguin
reviewed
Nov 14, 2025
| @@ -0,0 +1,48 @@ | |||
| <template> | |||
| <PolarIconButton | |||
Member
There was a problem hiding this comment.
If #399 is merged before this PR, this button should have no box-shadow.
# Conflicts: # examples/snowbox/GeoLocationMock.ce.vue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Migrate GeoLocation plugin to @polar/polar.
Instructions for local reproduction and review
Run and test in snowbox. Also take a walk with your mobile device when trying this.
Disable the
denkmaelerWMSlayer for mobile tests. Also note, that the heading will only be available in a HTTPS setting and with movement.Relevant tickets, issues, et cetera
Closes #347
If #374 is merged before this PR, then the
PinsOptionsshould be extended byLayerBoundPluginOptions. Otherwise, this change has to be added to #374.Blocked by #404