Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Use include instead of find_package for CMake config #457

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Fix: Use include instead of find_package for CMake config #457

merged 2 commits into from
Feb 23, 2024

Conversation

spnda
Copy link
Contributor

@spnda spnda commented Feb 22, 2024

As discussed in #453.

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 22, 2024

Thanks for looking into this.

@cNoNim you don't see any issues with that change, right?

@cNoNim
Copy link
Contributor

cNoNim commented Feb 22, 2024

Yeah, I think my PR was a regression.

cNoNim
cNoNim reviewed Feb 22, 2024
View reviewed changes
cmake/CMakeLists.txt Outdated Show resolved Hide resolved
cNoNim
cNoNim reviewed Feb 22, 2024
View reviewed changes
cmake/CMakeLists.txt Outdated Show resolved Hide resolved
@cNoNim
Copy link
Contributor

cNoNim commented Feb 22, 2024

@Dav1dde maybe we should simplify the instructions?
Looks like it's enough:

# Path to glad cmake files
add_subdirectory("${PROJECT_SOURCE_DIR}/external/glad/cmake" glad_cmake)

@Dav1dde
Copy link
Owner

Dav1dde commented Feb 23, 2024

@Dav1dde maybe we should simplify the instructions?

Which instructions?

@Dav1dde Dav1dde merged commit adc3d7a into Dav1dde:glad2 Feb 23, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cNoNim cNoNim cNoNim approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@spnda @Dav1dde @cNoNim