-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Reworked first user experience to be more discoverable
Before user had to know to use "Tools->Review Changes" for dialog to appear Now after installing plugin, dialog will show up in bottom-right corner automatically only remaining action user will need to do, is click very visible "Start Review" button. I also added "Toggle" button with tooltip explaining about Spacebar and double-click.
- Loading branch information
1 parent
0583fc4
commit 23ed4b4
Showing
5 changed files
with
60 additions
and
70 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
15 changes: 10 additions & 5 deletions
15
src/org/openstreetmap/josm/plugins/davidkarlas/JosmReviewPlugin/JosmReviewPlugin.java
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,16 +1,21 @@ | ||
package org.openstreetmap.josm.plugins.davidkarlas.JosmReviewPlugin; | ||
|
||
import org.openstreetmap.josm.gui.MainApplication; | ||
import org.openstreetmap.josm.gui.MainMenu; | ||
import org.openstreetmap.josm.gui.MapFrame; | ||
import org.openstreetmap.josm.plugins.Plugin; | ||
import org.openstreetmap.josm.plugins.PluginInformation; | ||
|
||
public class JosmReviewPlugin extends Plugin { | ||
StartReviewAction startReviewAction; | ||
public JosmReviewPlugin(PluginInformation info) { | ||
super(info); | ||
|
||
startReviewAction = new StartReviewAction(); | ||
MainMenu.add(MainApplication.getMenu().toolsMenu, startReviewAction); | ||
} | ||
|
||
@Override | ||
public void mapFrameInitialized(MapFrame oldFrame, MapFrame newFrame) { | ||
ReviewListDialog existingDialog=MainApplication.getMap().getToggleDialog(ReviewListDialog.class); | ||
if (existingDialog != null) { | ||
oldFrame.removeToggleDialog(existingDialog); | ||
} | ||
newFrame.addToggleDialog(new ReviewListDialog()); | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters