-
-
Notifications
You must be signed in to change notification settings - Fork 2k
fix: save event is triggered frequently #510
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Thanks for the PR. I’m just wondering if we really need two Save buttons that do the same thing. What do you think? |
|
yes,I think you can delete the ChatPanel component save button,Because it is not easy to be found. the DrawIoEmbed component save button more user-friendly |
|
@coder-wangtao Yes, you are right, thanks of the idea. |
|
Glad to help you. If this helps you, you can merge and close this PR. thank you! |
|
@coder-wangtao Let's break down how saving works in draw.io:
The main problem we're hitting: We can fix this by using draw.io's built-in autosave feature. This is actually how the official draw.io app handles things: By turning autosave to true and using the onAutoSave callback, we'll automatically grab every change the user makes. This also means we won't need a separate "Save" button for this purpose anymore. |
|
@DayuanJiang I tried it. I didn't set autosave={true}, It can also save automatically. App's "Save" Button (Download icon in chat input), I just feel it's very strange. People usually edit in the editor, and use draw.io Native "Save" Button to save. like me, They won't use App's "Save" Button (Download icon in chat input) |
Yes, autosave is a good alternative solution. It helps users save changes locally. |
There is no need to remove the save button,you can do this to fix save dialog is triggered frequently