Skip to content

Commit

Permalink
Add missing SPELL_DAMAGE registrations
Browse files Browse the repository at this point in the history
I'm gonna assume that disabling this UNIT_DIED event here is intentional:
https://github.com/DeadlyBossMods/DBM-BfA/blob/master/DBM-Raids-BfA/BattleofDazaralor/JadefireMasters.lua#L27
  • Loading branch information
emmericp committed Feb 3, 2024
1 parent abe2fe4 commit ad7c121
Show file tree
Hide file tree
Showing 3 changed files with 6 additions and 2 deletions.
2 changes: 2 additions & 0 deletions DBM-Raids-BfA/BattleofDazaralor/ChampionofLight.lua
Original file line number Diff line number Diff line change
Expand Up @@ -21,6 +21,8 @@ mod:RegisterEventsInCombat(
"SPELL_AURA_APPLIED 284468 283619 283573 284469 283933 284436 282113 283582",
"SPELL_AURA_APPLIED_DOSE 283573",
"SPELL_AURA_REMOVED 283619 284468 284469 283933 284436",
"SPELL_PERIODIC_DAMAGE 283582",
"SPELL_PERIODIC_MISSED 283582",
"UNIT_DIED"
)

Expand Down
2 changes: 1 addition & 1 deletion DBM-Raids-BfA/BattleofDazaralor/JadefireMasters.lua
Original file line number Diff line number Diff line change
Expand Up @@ -24,7 +24,7 @@ mod:RegisterEventsInCombat(
"SPELL_AURA_APPLIED_DOSE 282037",
"SPELL_AURA_REMOVED 282037 285632 286425 286988 284656",
"CHAT_MSG_MONSTER_EMOTE",
-- "UNIT_DIED",
"UNIT_DIED",
"UNIT_SPELLCAST_SUCCEEDED boss1 boss2"
)

Expand Down
4 changes: 3 additions & 1 deletion DBM-Raids-BfA/Uldir/Ghuun.lua
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,9 @@ mod:RegisterEventsInCombat(
"UNIT_DIED",
"CHAT_MSG_RAID_BOSS_EMOTE",
"INSTANCE_ENCOUNTER_ENGAGE_UNIT",
"UNIT_SPELLCAST_SUCCEEDED boss1"
"UNIT_SPELLCAST_SUCCEEDED boss1",
"SPELL_DAMAGE 263326",
"SPELL_MISSED 263326"
)

--[[
Expand Down

0 comments on commit ad7c121

Please sign in to comment.