Skip to content

Commit

Permalink
Fix numerous cases where count was missing, or wrong object type was …
Browse files Browse the repository at this point in the history
…set (also causing count to be missing)

Disabled some false diagnostics reports as well
  • Loading branch information
MysticalOS committed Jun 16, 2024
1 parent 3830e4c commit 5798a17
Show file tree
Hide file tree
Showing 5 changed files with 7 additions and 6 deletions.
2 changes: 1 addition & 1 deletion DBM-Raids-Shadowlands/CastleNathria/SireDenathrius.lua
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ local timerNextPhase = mod:NewPhaseTimer(16.5, 328117, nil, nil, nil, 6, n
--Stage Two: The Crimson Chorus
mod:AddTimerLine(DBM:EJ_GetSectionInfo(22059))
----Crimson Cabalist
local warnCrimsonCabalists = mod:NewSpellAnnounce("ej22131", 2, 329711)
local warnCrimsonCabalists = mod:NewCountAnnounce("ej22131", 2, 329711)
local warnCrescendo = mod:NewSpellAnnounce(336162, 3)

local specWarnCrescendo = mod:NewSpecialWarningDodge(336162, false, nil, nil, 2, 2)
Expand Down
2 changes: 1 addition & 1 deletion DBM-Raids-Shadowlands/CastleNathria/TheCouncilofBlood.lua
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,7 @@ local timerDredgerServantsCD = mod:NewCDTimer(44.3, 330978, nil, nil, nil, 1
mod:AddTimerLine(DBM:EJ_GetSectionInfo(22199))--Two are dead
local warnCastellansCadre = mod:NewSpellAnnounce(330965, 2)--Two bosses dead
local warnFixate = mod:NewTargetAnnounce(330967, 3)--Two bosses dead (Veteran Stoneguard)
local warnSintouchedBlade = mod:NewSpellAnnounce(346790, 4)--Veteran Stoneguard
local warnSintouchedBlade = mod:NewCountAnnounce(346790, 4)--Veteran Stoneguard

local specWarnFixate = mod:NewSpecialWarningRun(330967, nil, nil, nil, 4, 2)--Two bosses dead

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -668,6 +668,7 @@ function mod:SPELL_CAST_SUCCESS(args)
specWarnMerciless:Show(self.vb.merciCount.." / "..soakCount.."x")
specWarnMerciless:Play("helpsoak")
else
---@diagnostic disable-next-line: param-type-mismatch
warnMerciless:Show(self.vb.merciCount.." ("..soakCount.."x)")
end
timerMercilessCD:Start(self.vb.merciCount < 7 and 21 or 41, self.vb.merciCount+1)
Expand Down
6 changes: 3 additions & 3 deletions DBM-Raids-Shadowlands/SanctumOfDomination/TheTarragrue.lua
Original file line number Diff line number Diff line change
Expand Up @@ -32,9 +32,9 @@ local warnChainsofEternity = mod:NewTargetNoFilterAnnounce(347269, 2)
local warnAnnihilatingSmash = mod:NewTargetAnnounce(347274, 4)
local warnPedatorsHowl = mod:NewTargetAnnounce(347283, 2)
local warnForgottenTorments = mod:NewSoonAnnounce(352368, 2)--When it's soon
local warnUpperReachesMight = mod:NewSpellAnnounce(352382, 2)--When it's happening
local warnMortregarsEchoes = mod:NewSpellAnnounce(352389, 2)--When it's happening
local warnSoulforgeHeat = mod:NewSpellAnnounce(352398, 2)--When it's happening
local warnUpperReachesMight = mod:NewCountAnnounce(352382, 2)--When it's happening
local warnMortregarsEchoes = mod:NewCountAnnounce(352389, 2)--When it's happening
local warnSoulforgeHeat = mod:NewCountAnnounce(352398, 2)--When it's happening
local warnTheJailersGaze = mod:NewTargetNoFilterAnnounce(347369, 4)
mod:AddBoolOption("warnRemnant", false, "announce", nil, nil, nil, 352368)--3 options are combined into 1, so they don't need bundling
local warnRemantPhysical = mod:NewCountAnnounce(352384, 2, nil, nil, false)--Physical
Expand Down
2 changes: 1 addition & 1 deletion DBM-Raids-Shadowlands/Sepulcher/AnduinWrynn.lua
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@ mod:RegisterEventsInCombat(
--]]
--Stage One: Kingsmourne Hungers
mod:AddTimerLine(DBM:EJ_GetSectionInfo(24462))
local warnBefouledBarrier = mod:NewSpellAnnounce(365295, 3, nil, nil, 300531)
local warnBefouledBarrier = mod:NewCountAnnounce(365295, 3, nil, nil, 300531)
local warnWickedStar = mod:NewTargetCountAnnounce(365030, 3, nil, nil, nil, nil, nil, nil, true)
local warnDominationWordPain = mod:NewTargetNoFilterAnnounce(366849, 3, nil, "Healer", 249194)

Expand Down

0 comments on commit 5798a17

Please sign in to comment.