Skip to content

Commit

Permalink
docker: use CMD instead of ENTRYPOINT
Browse files Browse the repository at this point in the history
  • Loading branch information
@DeedleFake
DeedleFake committed Jun 9, 2021
1 parent 87f5b78 commit fce94d4
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion Dockerfile
View file
Original file line number Diff line number Diff line change
Expand Up @@ -18,4 +18,4 @@ ENV PATH /
EXPOSE 8080
VOLUME /data/sips

ENTRYPOINT ["sips"]
CMD ["sips"]

3 comments on commit fce94d4

@josh
Copy link

@josh josh commented on fce94d4 Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Curious why you changed this? The former lets you pass flags a bit easier without having to restate the executable in addition to the image name. Is there a use case for using an entrypoint other than sips?

With the former entrypoint:

$ docker run sips -h

With cmd:

$ docker run sips sips -h

This project looks pretty neat btw!

@DeedleFake
Copy link
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I changed it because it made sipsctl awkward to use. You had to do docker run --entrypoint sipsctl sips <sipsctl args>.

@josh
Copy link

@josh josh commented on fce94d4 Jun 10, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, gotcha, I missed that those were separate binaries. Makes sense!

Please sign in to comment.