chore(deps): remove unused dependencies and dead components - #158
Conversation
|
@eleven-smg is attempting to deploy a commit to the Deen Bridge Team on Vercel. A member of the Team first needs to authorize it. |
|
No actionable comments were generated in the recent review. π βΉοΈ Recent review infoβοΈ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: β Files ignored due to path filters (1)
π Files selected for processing (9)
π€ Files with no reviewable changes (6)
WalkthroughThe PR removes unused socket configuration, dependencies, static data, debug tooling, and commented UI code. It also updates dashboard fallback navigation, adjusts reels client-directive regions, and documents the relationship between notification bell implementations. ChangesApplication cleanup
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related issues
Possibly related PRs
Suggested reviewers: π₯ Pre-merge checks | β 4 | β 1β Failed checks (1 inconclusive)
β Passed checks (4 passed)
β¨ Finishing Touches π‘ 1π οΈ Fix failing CI checks π‘
π§ͺ Generate unit tests (beta)
Comment |
What
Removes two unused runtime dependencies, one dead component, and the dead exports in lib/data.js. Verified against the live dev tree rather than the line numbers in the issue, which have moved.
Dependencies
socket.io-client and react-select-country-list appear nowhere outside package.json β zero imports across the tree. Removed via npm uninstall, so package-lock.json drops only those two plus their transitives (engine.io-client, engine.io-parser, socket.io-parser, @socket.io/component-emitter, xmlhttprequest-ssl, and their nested debug copies). All @next/swc-* platform entries are intact, so npm ci still resolves on Linux CI.
NEXT_PUBLIC_SOCKET_URL dropped from .env.example alongside them.
Dead code
Removing links also removes the four sidebar entries pointing at /dashboard/classes, /dashboard/assignments, /dashboard/exams and /dashboard/results β none of which exist as routes.
Bug fixed in passing
components/molecules/errors/NotFound.jsx sent users to /dashboard/classes when the history stack was too short β a 404 page redirecting to another 404. Now /dashboard.
The deleted books array also contained a malformed entry (id 16 was missing its closing brace, merging it into id 17 with duplicate keys).
Judgement call for review
I did not delete components/molecules/dashboard/Notybell.jsx. It is unreferenced, but it is a complete SSE-backed notification bell built on hooks/useNotificationSSE.js, which is live in the tree. The bell actually rendered by nav-header.jsx is the placeholder at components/atoms/dashboard/Notybell.jsx. Deleting the working implementation looked like a product decision rather than cleanup, so both files now carry a header comment stating which is live and which is pending. Happy to delete it in a follow-up if the SSE bell has been abandoned.
Overlap: open PRs #118 and #119 also delete components/DebugAuthLogs.jsx. Whichever merges second will need a trivial conflict resolution.
Verification
npm run lint clean (the two remaining warnings are pre-existing, in lib/actions/cached-api.js and lib/utils/cloudinaryUpload.js, both untouched here). npm run build succeeds β 33 static pages generated.
Closes #84
Summary by CodeRabbit
Bug Fixes
Removed Features
Chores