[WIP] Integration with DeepLabCut 3.0 - PyTorch Engine #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maximpavliv
suggested changes
Mar 4, 2025
Comment on lines
+58
to
+59
| - Feb 2021: DeepLabCut-Live! was featured in **Nature Methods**: [ | ||
| "Real-time behavioral analysis"](https://www.nature.com/articles/s41592-021-01072-z) |
There was a problem hiding this comment.
Suggested change
| - Feb 2021: DeepLabCut-Live! was featured in **Nature Methods**: [ | |
| "Real-time behavioral analysis"](https://www.nature.com/articles/s41592-021-01072-z) | |
| - Feb 2021: DeepLabCut-Live! was featured in **Nature Methods**: | |
| ["Real-time behavioral analysis"](https://www.nature.com/articles/s41592-021-01072-z) |
| resize=resize, | ||
| cropping=cropping, | ||
| dynamic=dynamic, | ||
| display=display, | ||
| max_detections=max_detections, |
There was a problem hiding this comment.
DLCLive's constructor doesn't have a max_detections argument
| iterator = range(n_frames) if (print_rate) or (display) else tqdm(range(n_frames)) | ||
| for i in iterator: | ||
| iterator = range(n_frames) | ||
| if print_rate or display: |
There was a problem hiding this comment.
Shouldn't we check if has_tqdm here?
| frame_width = int(cap.get(cv2.CAP_PROP_FRAME_WIDTH)) | ||
| frame_height = int(cap.get(cv2.CAP_PROP_FRAME_HEIGHT)) | ||
|
|
||
| vwriter = cv2.VideoWriter( |
There was a problem hiding this comment.
Let's name it vid_writer as in benchmark()? I find vid_writer indeed better
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull requests updates DeepLabCut-Live for models exported with DeepLabCut 3.0. TensorFlow models can still be used, and the code is siloed so that only the engine used to run the code is required as a package (i.e. no need to install TensorFlow if you want to run live pose estimation with PyTorch models).
If you want to give this PR a try, you can install the code in your local
condaenvironment by running:pip install "git+https://github.com/DeepLabCut/DeepLabCut-live.git@dlclive3"