Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: desktop client MFA #502

Merged
merged 11 commits into from
Jan 17, 2024
Merged

feat: desktop client MFA #502

merged 11 commits into from
Jan 17, 2024

Conversation

wojcik91
Copy link
Contributor

@wojcik91 wojcik91 commented Jan 16, 2024

Description

Implements gRPC endpoints necessary for desktop client MFA.

Dev Branch Merge Checklist:

  • I have prepared end-to-end tests for all new functionalities
  • I have performed end-to-end tests manually and they work
  • New and existing unit tests pass locally with my changes
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding/required changes to deployment (Docker, Kubernetes, one-line install)
  • My changes generate no new warnings

Main Branch Merge Checklist:

  • I have merged my changes before to dev and the dev checklist is done
  • I have tested all functionalities on the dev instance and they work
  • I have made corresponding changes to the documentation and added new features documentation with screenshots for users/admins

@wojcik91 wojcik91 requested a review from moubctez January 16, 2024 15:53
src/db/models/group.rs Outdated Show resolved Hide resolved
src/grpc/mod.rs Outdated Show resolved Hide resolved
src/grpc/mod.rs Outdated Show resolved Hide resolved
@wojcik91 wojcik91 merged commit 79b3f03 into dev Jan 17, 2024
1 check passed
@wojcik91 wojcik91 deleted the desktop_client_mfa branch January 17, 2024 11:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants