Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rate limit MFA #51

Merged
merged 11 commits into from
May 10, 2024
Merged

Rate limit MFA #51

merged 11 commits into from
May 10, 2024

Conversation

moubctez
Copy link
Contributor

@moubctez moubctez commented Feb 3, 2024

No description provided.

@moubctez moubctez requested a review from wojcik91 February 3, 2024 19:41
@moubctez moubctez changed the base branch from main to dev February 5, 2024 06:41
@wojcik91
Copy link
Contributor

This approach (global rate limit) would the proxy to simple DDoS attacks. We need to implement at least a per-IP rate limit.
We could still follow the build in approach (https://docs.rs/tower/latest/src/tower/limit/rate/service.rs.html) and just add a map to track multiple client (remember to add some map cleanup to avoid infinite growth).

@j-chmielewski j-chmielewski merged commit 5271e76 into dev May 10, 2024
@j-chmielewski j-chmielewski deleted the rate_limit_mfa branch May 10, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants