handle 503 - service unavailable from token endpoint correctly

DefactoSoftware · May 24, 2019 · 30818a2 · 30818a2
1 parent 909d144
commit 30818a2
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 2 deletions.
diff --git a/lib/ueberauth/adfs.ex b/lib/ueberauth/adfs.ex
@@ -107,6 +107,11 @@ defmodule Ueberauth.Strategy.ADFS do
 
       {:error, %OAuth2.Response{body: %{"error_description" => reason}}} ->
         set_errors!(conn, [error("Authentication Error", reason)])
+
+      {:error, %OAuth2.Response{body: _, status_code: 503}} ->
+        set_errors!(conn, [
+          error("Authentication Error", "Service Unavailable - Contact the identity provider")
+        ])
     end
   end
 

diff --git a/test/ueberauth_adfs/adfs_test.exs b/test/ueberauth_adfs/adfs_test.exs
@@ -14,7 +14,6 @@ defmodule Ueberauth.Strategy.ADFSTest do
               client_id: "example_client",
               resource_identifier: "example_resource"
 
-
   @env_handler_values adfs_url: "https://example.com",
                       adfs_metadata_url: "https://example.com/metadata.xml",
                       adfs_handler: Ueberauth.Strategy.ADFSTestHandler,
@@ -185,7 +184,7 @@ defmodule Ueberauth.Strategy.ADFSTest do
         [error] = ADFS.handle_callback!(%Plug.Conn{params: %{"code" => "1234"}})
 
         assert error == %Ueberauth.Failure.Error{
-                 message: "Service Unavailable",
+                 message: "Service Unavailable - Contact the identity provider",
                  message_key: "Authentication Error"
                }
       end