Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a filter for Findings for Has Any JIRA (grouped or single) #11313

Open
wants to merge 2 commits into
base: bugfix
Choose a base branch
from

Conversation

hblankenship
Copy link
Collaborator

[sc-4131]

Added a filter for Has Any JIRA which will filter the findings on having group jira or jira_issue. This will also allow a dashboard tile to exist that shows all findings with any type of JIRA issue.

Copy link

DryRun Security Summary

The code change introduces a new filter in the Django application to allow users to filter findings based on whether they have a JIRA issue associated with them, as part of the application's vulnerability management capabilities and JIRA integration, with potential security considerations around the JIRA integration, sensitive information exposure, the complexity of "Finding Groups", and the importance of a robust permissions and authorization system.

Expand for full summary

Summary:

This code change introduces a new filter called "FindingHasJIRAFilter" in the Django application, which allows users to filter findings based on whether they have a JIRA issue associated with them or not. This feature is part of the application's vulnerability management capabilities and integration with the JIRA issue tracking system.

From an application security perspective, the key points to consider are the potential risks associated with the JIRA integration, the exposure of sensitive information through the filtering functionality, the complexity introduced by the "Finding Groups" feature, and the importance of having a robust permissions and authorization system to ensure that users can only access and perform actions that they are authorized to do. It is crucial to ensure that the implementation of these features is done securely, with appropriate controls and safeguards in place to protect sensitive information and prevent unauthorized access or actions.

Files Changed:

  • dojo/filters.py: This file has been updated to include the implementation of the new "FindingHasJIRAFilter" filter. This filter is used to allow users to filter findings based on whether they have a JIRA issue associated with them or not. The code also suggests the existence of "Finding Groups", which allow multiple findings to be grouped together, and a permissions and authorization system with various roles and permissions defined.

Code Analysis

We ran 9 analyzers against 1 file and 0 analyzers had findings. 9 analyzers had no findings.

Riskiness

🟢 Risk threshold not exceeded.

View PR in the DryRun Dashboard.

@@ -1610,6 +1640,7 @@ class FindingFilterHelper(FilterSet):
lookup_expr="isnull",
exclude=True,
label="Has Group JIRA")
has_any_jira = FindingHasJIRAFilter(label="Has Any JIRA")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
has_any_jira = FindingHasJIRAFilter(label="Has Any JIRA")
has_any_jira = FindingHasJIRAFilter(label="Has Any JIRA")

This should be present if groups are enabled or not, since regular jira links are a part of this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants