Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adding support of other btc assets. #12690

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

zluqo
Copy link
Contributor

@zluqo zluqo commented Dec 12, 2024

NOTE

Please enable "Allow edits by maintainers" while putting up the PR.


  • If you would like to add a volume adapter please submit the PR here.
  • If you would like to add a liquidations adapter, please refer to this readme document for details.
  1. Once your adapter has been merged, it takes time to show on the UI. If more than 24 hours have passed, please let us know in Discord.
  2. Sorry, We no longer accept fetch adapter for new projects, we prefer the tvl to computed from blockchain data, if you have trouble with creating a the adapter, please hop onto our discord, we are happy to assist you.
  3. Please fill the form below only if the PR is for listing a new protocol else it can be ignored/replaced with reason/details about the PR
  4. For updating listing info It is a different repo, you can find your listing in this file: https://github.com/DefiLlama/defillama-server/blob/master/defi/src/protocols/data2.ts, you can edit it there and put up a PR
  5. Do not edit/push package-lock.json file as part of your changes, we use lockfileVersion 2, and most use v1 and using that messes up our CI
  6. No need to go to our discord and announce that you've created a PR, we monitor all PRs and will review it asap

Name (to be shown on DefiLlama):
Twitter Link:
List of audit links if any:
Website Link:
Logo (High resolution, will be shown with rounded borders):
Current TVL:
Treasury Addresses (if the protocol has treasury)
Chain:
Coingecko ID (so your TVL can appear on Coingecko, leave empty if not listed): (https://api.coingecko.com/api/v3/coins/list)
Coinmarketcap ID (so your TVL can appear on Coinmarketcap, leave empty if not listed): (https://api.coinmarketcap.com/data-api/v3/map/all?listing_status=active,inactive,untracked&start=1&limit=10000)
Short Description (to be shown on DefiLlama):
Token address and ticker if any:
Category (full list at https://defillama.com/categories) *Please choose only one:
Oracle Provider(s): Specify the oracle(s) used (e.g., Chainlink, Band, API3, TWAP, etc.):
Implementation Details: Briefly describe how the oracle is integrated into your project:
Documentation/Proof: Provide links to documentation or any other resources that verify the oracle's usage:
forkedFrom (Does your project originate from another project):
methodology (what is being counted as tvl, how is tvl being calculated):
Github org/user (Optional, if your code is open source, we can track activity):

@llamabutler
Copy link

The adapter at projects/bitflux exports TVL:

core                      29.35 M

total                    29.35 M 

g1nt0ki added a commit that referenced this pull request Dec 13, 2024
@g1nt0ki
Copy link
Member

g1nt0ki commented Dec 13, 2024

hi @zluqo I have added the new pools here: b8ca316

But we dont like putting custom pricing/token mapping in the adapter, prefer doing that on our coins server, this way, all tvl adapters behave the same. How are these tokens bridged to code? suBTC/nexusBTC & pumpBTC.

Is suBTC sumer synth token? if so, I am not sure how 13 suBTC is deposited in your pool when circulating supply is less than 1 https://app.sumer.money/analytics/?chain=810180
image

Copy link
Member

@g1nt0ki g1nt0ki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@g1nt0ki g1nt0ki self-assigned this Dec 13, 2024
@xiaohanzhu
Copy link

Thank you for pointing the issue. We haven't updated the pie chart to include the circulation on Core network (since the lending and CDP engine is not deployed yet). The suBTC were minted on zklink and bridged to Core. We just updated the UI to show where the suBTC were minted so you will have a better idea of the collaterals. Feel free to verify again.

hi @zluqo I have added the new pools here: b8ca316

But we dont like putting custom pricing/token mapping in the adapter, prefer doing that on our coins server, this way, all tvl adapters behave the same. How are these tokens bridged to code? suBTC/nexusBTC & pumpBTC.

Is suBTC sumer synth token? if so, I am not sure how 13 suBTC is deposited in your pool when circulating supply is less than 1 https://app.sumer.money/analytics/?chain=810180 image

@zluqo
Copy link
Contributor Author

zluqo commented Dec 15, 2024

@g1nt0ki on your suggestion of adding suBTC, nBTC and pumpBTC to coin server here is the initial commit which includes suBTC only.

BitFluxFi/defillama-server@6da9685

Can you check and let us know if this make sense? I will open PR later.

@xiaohanzhu
Copy link

xiaohanzhu commented Dec 17, 2024

Hi @zluqo please see the updated pie charts. Let us know if any additional information or fixes are needed for this PR.
btw, here is the coingecko API link for suBTC price:

https://api.coingecko.com/api/v3/simple/price?ids=sumer-money-subtc&vs_currencies=usd

Thank you very much for your help!

image

hi @zluqo I have added the new pools here: b8ca316

But we dont like putting custom pricing/token mapping in the adapter, prefer doing that on our coins server, this way, all tvl adapters behave the same. How are these tokens bridged to code? suBTC/nexusBTC & pumpBTC.

Is suBTC sumer synth token? if so, I am not sure how 13 suBTC is deposited in your pool when circulating supply is less than 1 https://app.sumer.money/analytics/?chain=810180 image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants