Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change UI's #445

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Change UI's #445

wants to merge 2 commits into from

Conversation

veebull
Copy link

@veebull veebull commented Apr 11, 2023

Some ui changes

  • Added ability to copy RPC link to clipboard after clicking on the link text
  • Added an effect of adding icon to the clipboard when hovering over a cell with a link
  • Added effect of highlighting a cell with color when pointing with cursor
  • Added animation of adding a link to the clipboard
  • Fixed bug when switching to dark mode, scrolling remained always white in chrome. Now when you change the theme, scrolling is always in the theme color
  • Added full screen mode, side menu folds into side menu. Looks much more convenient, especially for laptops.
  • Tables on mobile resolution became more organic.
  • Small bugs on mobile resolution.
  • Added remembering the position of the side menu or full screen mode in localStorage.

Take the best, leave the rest.

@vercel
Copy link

vercel bot commented Apr 11, 2023

@amiuttt is attempting to deploy a commit to the Defillama Team Team on Vercel.

A member of the Team first needs to authorize it.

@mintdart
Copy link
Contributor

hey can you resolve merge conflicts and revert changes in yarn.lock file?

@mintdart
Copy link
Contributor

i don't see jsx and styled-jsx packages used anywhere, can you revert changes in package.json, yarn.lock and remove package-lock.json ?

@veebull
Copy link
Author

veebull commented Apr 18, 2023

Ok, it is not problem. I removed jsx and jsx-styled and decide to check with editing new ExtraRpcs.js and after npm run dev it shows error - SerializableError: Error serializing .chains[0].rpc[22].trackingDetailsreturned fromgetStaticProps in "/" so where I must add new line of code to solve this issue.

@mintdart
Copy link
Contributor

can you revert changes in extraRpcs.js and keep this PR relevant to only UI changes ? , please revert changes in extraRpcs.js , yarn.lock, package.json and remove package-lock.json

@veebull
Copy link
Author

veebull commented Apr 26, 2023

can you revert changes in extraRpcs.js and keep this PR relevant to only UI changes ? , please revert changes in extraRpcs.js , yarn.lock, package.json and remove package-lock.json

Done, i think...

@veebull
Copy link
Author

veebull commented Apr 26, 2023

can you revert changes in extraRpcs.js and keep this PR relevant to only UI changes ? , please revert changes in extraRpcs.js , yarn.lock, package.json and remove package-lock.json

I saw that you added new cell for ad in html. Hope it would be solve without my participate

Copy link
Contributor

@mintdart mintdart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please revert changes in constants/chainIds.json , constants/extraRpcs.js , rebase your branch with main and resolve merge conflicts, thanks 🙏

Copy link

@Dioliode Dioliode left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

DioX

@tranthanhkiet
Copy link

Some ui changes

  • Added ability to copy RPC link to clipboard after clicking on the link text
  • Added an effect of adding icon to the clipboard when hovering over a cell with a link
  • Added effect of highlighting a cell with color when pointing with cursor
  • Added animation of adding a link to the clipboard
  • Fixed bug when switching to dark mode, scrolling remained always white in chrome. Now when you change the theme, scrolling is always in the theme color
  • Added full screen mode, side menu folds into side menu. Looks much more convenient, especially for laptops.
  • Tables on mobile resolution became more organic.
  • Small bugs on mobile resolution.
  • Added remembering the position of the side menu or full screen mode in localStorage.

Take the best, leave the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants