Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update oracles and chains for Primex Finance #7658

Closed
wants to merge 1 commit into from

Conversation

Mar-Alex
Copy link

@Mar-Alex Mar-Alex commented Aug 5, 2024

No description provided.

@realdealshaman
Copy link
Collaborator

Hey @Mar-Alex thanks for the PR! I see that only Pyth is mentioned in their docs. Please update it to only Pyth and add the reference link https://docs.primex.finance/guides/what-is-primex/economic-security/oracles/pyth-network-oracle and we'll get it merged

@Mar-Alex
Copy link
Author

Mar-Alex commented Aug 7, 2024

@realdealshaman
Copy link
Collaborator

Thanks for the additional info, @Mar-Alex ! Can you tell us which is your primary oracle? To add the correct oracle that secures the protocol's TVL, we need to know: If the oracle gets hacked, would 50% of the protocol's TVL be at risk? We need to ask this for Chainlink and Pyth, but it seems this is not the case for Umbrella, as it is just a gas TWAP for keepers

@Mar-Alex
Copy link
Author

Mar-Alex commented Aug 8, 2024

@realdealshaman Currently, the security of the protocol mostly depends on Chainlink, but we are switching to Pyth to increase the number of supported pairs. If CL or Pyth is hacked, the protocol TVL would be at risk.

Regarding Umbrella, you are right, they don't protect TVL directly, it's more about correct keeper reward calculation.

@realdealshaman
Copy link
Collaborator

@Mar-Alex got it, then we'd have to add chainlink for now since it is the oracle securing the tvl and we can add Pyth later once it is used and has considerable tvl at risk if it were hacked

@Mar-Alex
Copy link
Author

Mar-Alex commented Aug 8, 2024

@realdealshaman Is it possible to mention several oracles, as we depend on all of them, or at least both Chainlink and Pyth? Pyth's importance for the protocol will expand rather fast during the next weeks.

@realdealshaman
Copy link
Collaborator

@Mar-Alex We need to only mention the oracles securing the TVL. We can add more than one but only once Pyth is securing a significant part of the TVL, otherwise the total amount of the TVL will also be attributed to them incorrectly

@realdealshaman
Copy link
Collaborator

I've added Chainlink as per the comment above, please let us know when Pyth is more widely used and can be considered the primary oracle and we can update the listing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants