feat(dopex): holder and supply side revenue #1277
Conversation
|
The dopex adapter exports: |
|
The dopex adapter exports: |
options/dopex/clamm.ts
Outdated
| @@ -74,23 +77,23 @@ async function getChainStats({ graphUrl, timestamp }: IGetChainStatsParams) { | |||
| (acc, market) => { | |||
| return { | |||
| dailyNotionalVolume: acc.dailyNotionalVolume + Number(market.volume), | |||
| dailyPremiumVolume: acc.dailyPremiumVolume + Number(market.premium), | |||
| dailyFees: acc.dailyFees + Number(market.premium), | |||
There was a problem hiding this comment.
for options we can't include premium on fees
There was a problem hiding this comment.
Oh okay! Can you suggest how can we show premiums as premiums and not as premium volume (which is only visible on a graph). premiums should be shown in the side bars as well along with fees, revenue etc.
There was a problem hiding this comment.
you mean rev 24h, it is wrong file is should be 24h premiums data we will fix
There was a problem hiding this comment.
Yes, 24h revenue should show as premiums 24h. anyways I've updated the code to show only revenue and not fees since they're the same data :)
There was a problem hiding this comment.
premiums should show here on the left panel too
There was a problem hiding this comment.
no fees is only add on fees when user buy option premium is not fees
There was a problem hiding this comment.
Yes, 24h revenue should show as premiums 24h. anyways I've updated the code to show only revenue and not fees since they're the same data :)
if you need update fees/rev plz set at field dailyFees, dailyRevenue
now current adapter set fees = rev then show fees = rev premiums is show only options page
There was a problem hiding this comment.
If that's the case, no change has to be made and this PR can be closed. Our only concern is premiums not showing in main options page or anywhere except in just the bar graph as premium volume which as you mentioned will be fixed :)
There was a problem hiding this comment.
yes will take look why option is show daily rev instead daily premium
There was a problem hiding this comment.
Hey! updated the PR to just show more stats as per teams feedback :) please review
|
The dopex adapter exports: |
Aercwarden
changed the title
|
The dopex adapter exports: |
Aercwarden
changed the title
| @@ -88,9 +92,11 @@ async function getChainStats({ graphUrl, timestamp }: IGetChainStatsParams) { | |||
| return { | |||
| timestamp, | |||
| ...cumulative, | |||
| totalFees: cumulative.totalRevenue, | |||
| ...daily, | |||
There was a problem hiding this comment.
fees is require dailyFees we can't list without dailyFees
There was a problem hiding this comment.
In our context, this will be protocol fees + premium?
dailyFees = daily protocol fees + daily premium?
when a user purchases options on stryke they pay premium + protocol fees
Current implementation shows same data for daily revenue and daily fees this PR fixes that
current:
with fix:
