Added Bitoro Volume Adapter #1402
Conversation
|
The bitoro adapter exports: |
| const makeRequest = (startTime: number, endTime: number) => bitoroApiVolumeEndpoint + `?start=${startTime}&end=${endTime}` | ||
|
|
||
| const fetch = async (timestamp: number) => { | ||
| const startOfDayTimestamp = getUniqStartOfTodayTimestamp(new Date(timestamp * 1000)) + 86400 |
There was a problem hiding this comment.
why start time is day +1 ?
There was a problem hiding this comment.
I'm under the impression that 24hr volume is meant to be calculated for the current day, not the day before. getUniqStartOfTodayTimestamp gives the end of the prior day and we wanted start of current day. Is 24 hour volume meant to be for the day prior? I can see how this can be an issue with custom backfill
There was a problem hiding this comment.
No tvl adapter. Still waiting on endpoint.
There was a problem hiding this comment.
Can we not merge the volume adapter without a TVL adapter?
There was a problem hiding this comment.
ppl will complaint why that protocol does not tvl but volume high is it fake volume and will delist
Adapter returns daily and total volumes and supports custom backfill.